Notepad++ UWP package in Windows store - almost there
It’s almost done, but it has been blocked - we need Microsoft (or UWP expert) support so we have a stable way to build UWP package for each release.
I have managed to have a Notepad++ UWP package and have tested it in July 2017. However more work needed to be done in order to adapt Notepad++ to UWP package’s nature.
In end of Auguest 2017, the adaptation has been finished so I released 7.5.1 for the desktop firstly. Afterward I’ve tried to build Notepad++ UWP package with the same command for Windows Store: surprise - the build failed with the following error:
C:\WINDOWS\system32>DesktopAppConverter.exe -Installer C:\sources\notepad-plus-plus\PowerEditor\installer\build\npp.7.5.1.Installer.x64.exe -InstallerArguments /noUpdater -Destination C:\tmp -PackageName "Npp" -Publisher "CN=notepad-plus-plus.com" -Version 22.214.171.124 -MakeAppx C:\Program Files\WindowsApps\Microsoft.DesktopAppConverter_126.96.36.199_x64__8wekyb3d8bbwe\DesktopAppConverter.ps1 : DesktopAppConverter : error 'E_STARTING_ISOLATED_ENV_FAILED': Failed to start the isolated environment. See inner exception for more details. At line:1 char:1 + &'C:\Program Files\WindowsApps\Microsoft.DesktopAppConverter_188.8.131.52_ ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : NotSpecified: (:) [Write-Error], WriteErrorException + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,DesktopAppConverter.ps1 Output Paths: Name Value ---- ----- CertPath PackageFilesPath PackagePath LogFilesPath C:\tmp\Npp\logs
Here is the log: https://notepad-plus-plus.org/temp/DesktopAppConverter (1).log
Then I try on the 2 others PC with another application that I have managed to build - same result.
The different results on same configuration with the same installers to build makes me deduct the conclusion: the source of problem comes from Windows Update.
Please let me know if anyone has any idea for why and how ( my email is firstname.lastname@example.org ).
@Scott-Sumner Just to be clear… this version is “as real” as the packaged versions currently running on Ubuntu or OSX. Only minor modifications have been made to the code in order to meet store policies - but otherwise its original (and its on GitHub so you can verify that). I am now also using appveyor to fully automate the build process. There is no reason why Don or team could not publish this themselves… or publish this version officially.
Only minor modifications have been made to the code
That is what makes it a different product.
@Scott-Sumner … if you say so. Its 5 lines; and 3 of those are me pointing to my own signing certificate instead of the original. This is the only other change (the remaining 2 lines)…
If upstream would like to remove that cmd run dialog, Notepad++ would be fully compliant with store policies, and no code changes would be required at all.
As always, if someone from the core team would like to publish an official version of Notepad++ to the windows store (so users of Win 10S, or under app control enforcement) are still able to use this great tool - I will fully support them in doing so, and move my deployment over to them (or I will also transfer my repo if you prefer to keep it as a different branch).
If users run into a bug on the store version… chances are its a bug on the native version as well. There is no differences there.
I still believe the “team” doesn’t want the product on the Store, for whatever the reason. That should be the end of it.
@Scott-Sumner 163,334 Installs and 15000-18000 daily active user sessions would imply they should reconsider that…
As donho seems no to be actively working at that task (also he did in the past) i think it is ok to have a guy who takes that place in the meantime until donho makes a clear statement if the current state is ok and official or he would like to take care on it.
Seems the necessary changes for the store could be made configurable (build parameters of dynamic config values) and added as PR to the upstream project
So AFAIK when changes are made to Notepad++ they are done in the form of a PR. If @donho chooses to accept the PR then it is so done, otherwise it is not done (obviously). So the proper way to have gone about this would have been to prepare a PR, say “hey, Don, here’s a PR for the Windows Store” (hint: all the work is done for you, you just have to adopt it by accepting this PR), and wait and see what happens with it. If it gets accepted, Great. If not, you have to swallow that and move on.
@chcg, I’m kind of surprised at your stance on this. The fact that Don worked on this in the past isn’t all that relevant. For all we know he hit something he didn’t like and decided not to move forward with it. His project, his prerogative. It’s nice when he shares his reasoning with us, but he’s under no obligation to do so.
And sure, open source is open source. Do what you like with it. But I personally have a problem with what was done, because it inserts something that appears (to the masses) to be Notepad++ into a major distribution channel. And regardless of how little was changed, it is not Notepad++.
I’m surprised Don didn’t work harder to get the fork taken down from the Store or at least significantly renamed. But…again because we are in the dark…maybe he did and was unsuccessful. I’m sure the people at Microsoft weren’t in a big hurry to side with him.
I really don’t have much more to say about it–for which I’m sure some people are glad. :-)
Thanks @chcg - at some point here I will get a PR in to atleast see if he will take the dynamic config values to remove run… although signing verification will still be a PITA unless he can also build and sign versions with that set. This is one of those things where colaberation would be great.
In an ideal state… https://github.com/notepad-plus-plus would get another repo, with all the packaging components - embedded plugins, Lang files, config files ect. You could then have a separate appveyor config to build the upstream with the right flag, sign, and package. Thats a little more work than just a PR unfortunately - but once setup - like my repo there is very little overhead.
open source is open source
Yep… and I think thats why MS let it stay in the store. That and this thread where I am totally willing to let Don manage it if he wants - if not - well its a legit clone under GPL. Note a fake… not a different product… a fork yes, but its still notepad++ just avalible to the masses. Lets also not forget this is out there:
This is not the only instance where someone other than Don is maintaining a packaged version of the in a main stream store.
I like the title of this related Notepad++ issue…a lot !